Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swr to 1.1.1 in order to pick up Andrew's feature work #2610

Closed
humphd opened this issue Dec 14, 2021 · 2 comments · Fixed by #2630
Closed

Update swr to 1.1.1 in order to pick up Andrew's feature work #2610

humphd opened this issue Dec 14, 2021 · 2 comments · Fixed by #2630
Assignees
Labels
area: front-end dependencies Pull requests that update a dependency file type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Dec 14, 2021

One of my goals for 2022 is that we start to become more outward facing in our Telescope contributions, and find ways to give back to the projects that we depend upon. Christmas came early and we have one of our first examples of what this looks like. One of our favourite front-end dependencies is Vercel's swr, and our colleague @Andrewnt219 has been on an epic journey adding a new feature to it:

This work has been shipped upstream in v1.1.1. Let's update in order to get the benefits in Telescope!

@humphd humphd added type: enhancement New feature or request area: front-end dependencies Pull requests that update a dependency file labels Dec 14, 2021
@Andrewnt219
Copy link
Contributor

Thanks for the shout-out. I'll happily make this upgrade.

As for its use, I can only think of this case where backend includes an interval in the response

@humphd
Copy link
Contributor Author

humphd commented Dec 14, 2021

We don't need to find a way to use the feature, I just want it updated as reflection of the work, and what it represents. This is the way to exist in the open source ecosystem: dependencies should be something we use, but also something we help maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: front-end dependencies Pull requests that update a dependency file type: enhancement New feature or request
Projects
None yet
2 participants