Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy backend #2777

Closed
humphd opened this issue Jan 29, 2022 · 6 comments
Closed

Remove legacy backend #2777

humphd opened this issue Jan 29, 2022 · 6 comments
Assignees
Labels
area: back-end area: docker dependencies Pull requests that update a dependency file developer experience Helping the Developer Experience type: enhancement New feature or request
Milestone

Comments

@humphd
Copy link
Contributor

humphd commented Jan 29, 2022

As we prepare to migrate away from the legacy backend, and toward a pure microservices approach, I'd like to switch the repo around a little bit. Specifically:

  • create src/legacy
  • move test/ to src/legacy/test
  • move contents of src/backend to src/legacy/src
  • create a package.json in src/legacy
  • move all aspects of the root package.json that are specific to the legacy backend to src/legacy/package.json (e.g., all dependencies for the backend should go in the root package).
  • add src/legacy to the pnpm workspace list
  • update eslintrc.js so it knows about src/legacy
  • update test/jest.config.js to point to the correct place
  • Move and update the Dockerfile for the backend out of the root and into src/legacy/Dockerfile
  • update any references in docs or other files that use src/backend to point to the new locations
  • update relative links from tests or other source files, so things still work
  • update .vscode/launch.json
  • etc

When this is done, it's going to be easier to use turborepo, since all of our projects will be workspaces, and there will be nothing in the root except our tooling.

It will also mean that all of our sub-projects will use the same general layout, with their own src, test, Dockerfile, etc.

Later, we'll be able to dump src/legacy as a whole.

@humphd humphd added type: enhancement New feature or request area: back-end area: docker developer experience Helping the Developer Experience dependencies Pull requests that update a dependency file labels Jan 29, 2022
@humphd humphd added this to the 2.7 Release milestone Jan 29, 2022
@HyperTHD
Copy link
Contributor

This sounds like alot of work that's really unnecessary. The only service blocking the backend folder from being deleted is the parser service. I get wanting to make more use of turborepo, but considering it'll eventually be deleted, this just sounds like work we can ignore no?

@humphd
Copy link
Contributor Author

humphd commented Jan 30, 2022

It's a fair question. The reason I think that this is a valuable exercise is that it helps the current team to define the boundaries of the old vs. new code. Doing this work will be necessary in order to remove the old code, and if we don't know where it is, it's hard to do. Getting rid of the backend isn't quite as simple as turning on the parser service and deleting src/backend, as you can see above.

@tpmai22
Copy link
Contributor

tpmai22 commented Mar 8, 2022

@TueeNguyen would be great if you can shred some light on this.

@TueeNguyen TueeNguyen changed the title Isolate legacy backend in src/legacy Remove legacy backend Apr 6, 2022
@TueeNguyen
Copy link
Contributor

We're removing the backend instead of isolating it

@TueeNguyen TueeNguyen modified the milestone: 3.0 Release Apr 22, 2022
@manekenpix
Copy link
Member

Since the legacy backend was removed, I think this is no longer needed.

@sirinoks
Copy link
Contributor

WE DID IT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: back-end area: docker dependencies Pull requests that update a dependency file developer experience Helping the Developer Experience type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants