Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial tests for /github/:project #3412

Merged
merged 1 commit into from Apr 6, 2022
Merged

Add initial tests for /github/:project #3412

merged 1 commit into from Apr 6, 2022

Conversation

JerryHue
Copy link
Contributor

@JerryHue JerryHue commented Apr 6, 2022 •
edited

Issue This PR Addresses

Fixes #3331

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI
  • Test: Change that adds a new test case

Description

This PR adds some test cases to the route /github/:project/ in the dependency-discovery.

Steps to test the PR

I don't think you need to test this locally, just let CI do the checks for you 馃槈

However, if you insist:

  1. Get my changes,
  2. Run the tests for only the service so that it is faster (pnpm run jest dependency.test.js).

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@JerryHue JerryHue added this to the 3.0-alpha Release milestone Apr 6, 2022
@JerryHue JerryHue self-assigned this Apr 6, 2022
@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

humphd
humphd requested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove the console.logs

src/api/dependency-discovery/test/dependency.test.js Outdated Show resolved Hide resolved
src/api/dependency-discovery/test/dependency.test.js Outdated Show resolved Hide resolved
src/api/dependency-discovery/test/dependency.test.js Outdated Show resolved Hide resolved
dbelokon
dbelokon previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@dbelokon dbelokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me!

@JerryHue JerryHue requested review from humphd and dbelokon April 6, 2022 21:47
dbelokon
dbelokon approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@dbelokon dbelokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JerryHue JerryHue merged commit 9d376e8 into Seneca-CDOT:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@dbelokon dbelokon dbelokon approved these changes

@tcvan0707 tcvan0707 tcvan0707 approved these changes

Assignees

@JerryHue JerryHue

Labels
None yet
Projects
None yet
Milestone
3.0-alpha Release
Development

Successfully merging this pull request may close these issues.

Add tests for /github/:project in dependency-discovery
4 participants
@JerryHue @humphd @dbelokon @tcvan0707