Release 1.2.13 #56
Merged
Release 1.2.13 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bt0r
reviewed
Sep 26, 2022
manifest_firefox.json
Outdated
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "manifest_version": 2, | |||
| "name": "NoteFlix", | |||
| "name": "SensCritique", | |||
| "version": "1.2.11", | |||
There was a problem hiding this comment.
Upgrade la version en respectant semver :)
manifest_chrome.json
Outdated
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "manifest_version": 2, | |||
| "name": "NoteFlix", | |||
| "name": "SensCritique", | |||
| "version": "1.2.11", | |||
bt0r
reviewed
Sep 26, 2022
manifest_firefox.json
Outdated
| @@ -18,7 +18,6 @@ | |||
| } | |||
| ], | |||
| "permissions": [ | |||
| "*://www.allocine.fr/*", | |||
There was a problem hiding this comment.
Par contre si tu supprimes la permission à Allociné il faut supprimer le code aussi (sinon l'extension ne fonctionnera pas en l'état)
There was a problem hiding this comment.
Edit: tu as fait une autre PR pour ca donc tu peux rollback cette partie là et l'intégrer à l'autre PR (comme ca cette release reste fonctionnelle)
audreylamy
force-pushed
the
fix/new-name-logo
branch
from
031fa5f
to
a71ec62
Compare
audreylamy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #50