Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a utilities class that holds code that is re-used across classes #18

Open
tnigon opened this issue Apr 23, 2020 · 2 comments
Open

Create a utilities class that holds code that is re-used across classes #18

tnigon opened this issue Apr 23, 2020 · 2 comments
Labels
invalid This doesn't seem right
Projects
research_tools project

Comments

@tnigon
Copy link
Contributor

tnigon commented Apr 23, 2020

To start with, add _set_params_from_dict and _set_params_from_kwargs, which will be used by feature_data, feature_selection, tuning, and training.
@tnigon tnigon added the enhancement New feature or request label Apr 23, 2020
@tnigon tnigon self-assigned this Apr 23, 2020
@tnigon tnigon added this to To do in research_tools project Apr 23, 2020
@tnigon tnigon moved this from To do to In progress in research_tools project Apr 23, 2020
@tnigon tnigon moved this from In progress to To do in research_tools project Apr 23, 2020
@tnigon tnigon added invalid This doesn't seem right and removed enhancement New feature or request labels Apr 23, 2020
@tnigon
Copy link
Contributor Author

tnigon commented Apr 23, 2020

Flagging as invalid because I need a clean way to grab a specific part of param_dict (denoted with the "FeatureData" key for FeatureData, "FeatureSelection" for `FeatureSelection, etc.).

Instead, I'm thinking it will be fine to just include these functions in each class, modifying as necessary.

@tnigon
Copy link
Contributor Author

tnigon commented Apr 23, 2020

In any case, we should be able to access from any child classes via inheritance, so a new class isn't needed.

@tnigon tnigon removed their assignment Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
research_tools project
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tnigon