Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to call NBIRTH payload generate method explicitly #53

Closed
DarshitGandhi-net opened this issue Jun 23, 2023 · 4 comments
Closed

Unable to call NBIRTH payload generate method explicitly #53

DarshitGandhi-net opened this issue Jun 23, 2023 · 4 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@DarshitGandhi-net
Copy link

DarshitGandhi-net commented Jun 23, 2023

@SeppPenner
There is functionality in sparkplug specification where you can send NBIRTH message only if Host Application is online. So when Primary Host Application is online it will send STATE payload with online message after that you can send stored message in NBIRTH payload but in this Node.PublishInternal method for generating NBIRTH message of SparkPlugBase class it's directly publishing message without verifying Host app is online or not . Need this functionality for this .

@SeppPenner SeppPenner self-assigned this Nov 27, 2023
@SeppPenner SeppPenner added the enhancement New feature or request label Nov 28, 2023
@ankitagojiya
Copy link

Hello @SeppPenner ,
Any news on this ?

@SeppPenner
Copy link
Owner

Sorry, no. I'm currently working on the payload conversion. And I want to finish this finally (Yes, I already wrote that several times) within the next 3 to 4 days...

@ankitagojiya
Copy link

Hello @SeppPenner
Apologies for the repeated inquiries, but could you please provide an update on this?

Because if I want to send NBIRTH second time from already running application i need to call this Start("await node.Start(nodeOptions)") method because we don't have any explicit method to send NBIRTH and "Start" method will internally reconnect and subscribe topics unnecessary and also we have to subscribe to NCMD and STATE event also because it has established new connection so we won't get any STATE and NCMD message if we don't subscribe events again. It is good to make "await this.PublishInternal()" public or explore alternative solutions
This issue is impeding current implementations.

Related issue : #44

image

@SeppPenner SeppPenner added the duplicate This issue or pull request already exists label Mar 22, 2024
@SeppPenner
Copy link
Owner

This is a duplicate of #44, please follow the thread there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants