Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check endianess in conversions. #71

Closed
SeppPenner opened this issue Feb 22, 2024 · 4 comments
Closed

Check endianess in conversions. #71

SeppPenner opened this issue Feb 22, 2024 · 4 comments
Assignees
@SeppPenner
Labels
enhancement New feature or request

Comments

@SeppPenner
Copy link
Owner

From 2c0454f#commitcomment-138925118:

Just a note: The BitConverter.Get... and BitConverter.To.. will force the Indianness to the system architecture Indianness (not a problem if that is littleIndian) but in systems using BigIndian the conversion will be done in BigIndian.
System.Buffers.Binary.BinaryPrimitives provides methods for explicitly converting to from bytes in the desired Indianness format. (ReadInt32LittleEndian, WriteInt32LittleEndian).
@SeppPenner SeppPenner added the enhancement New feature or request label Feb 22, 2024
@SeppPenner SeppPenner self-assigned this Feb 22, 2024
@SeppPenner
Copy link
Owner Author

Just a marker for me, currently working on this.

@SeppPenner
Copy link
Owner Author

@all-contributors please add @shouidar for tests and code

@allcontributors allcontributors bot mentioned this issue Mar 3, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@SeppPenner

I've put up a pull request to add @shouidar! 🎉

@SeppPenner
Copy link
Owner Author

Fixed with https://github.com/SeppPenner/SparkplugNet/releases/tag/1.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeppPenner SeppPenner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SeppPenner