Remove dependency of Serilog

[tkouba]

Please remove dependency of Serilog.

[SeppPenner]

Why should I? It's honestly the best logging framework I have worked with until now...

[tkouba]

Because there are a lot of logging frameworks. Dependency of any logging framework from general use library is not a good idea. This dependency may violate some rules for application and library cannot be used.

[SeppPenner]

Because there are a lot of logging frameworks. Dependency of any logging framework from general use library is not a good idea. This dependency may violate some rules for application and library cannot be used.

I have thought a bit about this and I agree. I will check this and see what I can do.

[shouidar]

Although I agree that depending on SeriLog is overkill, I think the library should allow for some optional logging mechanism. This can be achieved easily by depending only on the Microsoft.Extensions.Logging.Abstractions and optionally the default ILogger or any compatible logging framework (including SeriLog if desired) or null if logging is not required. The library would prefix all local ILogger calls with the null check operator to handle the null logger case.
See "Loggin in a .Net Core library" for more details.

[SeppPenner]

The question is if we really need it. There was only debugging logs in the code. I mean, I can add it if desired.

[malavvvakharia]

@SeppPenner , On the NuGet side 1.3.4 is not available. So do 1.3.3 and 1.3.4 have the same code?

[SeppPenner]

@malavvvakharia I guess, I forgot to push it. Should be there soon 😅