Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Redis plugin #64

Closed
szepeviktor opened this issue Jul 30, 2017 · 7 comments
Closed

Switch Redis plugin #64

szepeviktor opened this issue Jul 30, 2017 · 7 comments
Assignees

Comments

@szepeviktor
Copy link

Till Krüss is a very good developer but Daniel produces a better plugin:
https://github.com/pantheon-systems/wp-redis

Please consider switching.

@ottok
Copy link
Contributor

ottok commented Aug 9, 2017

I see you are one of the authors. What other aspects makes it better? :)

@szepeviktor
Copy link
Author

szepeviktor commented Aug 9, 2017

The sentence SOME_STATEMENT but Daniel produces a better plugin is always true as Daniel works only for enterprise customers.

There is a high tension between plugin authors: there are enterprise and popular guys.
Enterprise guys produce plugins for controlled and optimized environments, popular guys target clients with shared hosting, and selling pro versions.

  • See tests and be shocked!
  • Till's plugins has uninstall.php which makes no sense
  • predis is surely not for optimized servers as the PECL extension is written in C
  • Cluster support
  • overall code quality
  • why I chose to contribute to wp-redis, not to the other one

@ottok
Copy link
Contributor

ottok commented Aug 24, 2017

I have now started a test with this. At least the wp-cli interface is rather nice:

$ wp redis info
+-------------------+-----------+
| Field             | Value     |
+-------------------+-----------+
| status            | connected |
| used_memory       | 29.59M    |
| uptime            | 0 days    |
| key_count         | 36960     |
| instantaneous_ops | 2005/sec  |
| lifetime_hitrate  | 44.67%    |
| redis_host        | null      |
| redis_port        | 6379      |
| redis_auth        |           |
| redis_database    | 0         |
+-------------------+-----------+

@ottok
Copy link
Contributor

ottok commented Aug 24, 2017

The vanilla Redis stats in comparison:

$ redis-cli info stats
# Stats
total_connections_received:29309
total_commands_processed:143619952
instantaneous_ops_per_sec:24
rejected_connections:0
sync_full:0
sync_partial_ok:0
sync_partial_err:0
expired_keys:20
evicted_keys:16105240
keyspace_hits:11539283
keyspace_misses:14112309
pubsub_channels:0
pubsub_patterns:0
latest_fork_usec:0

@JoosuaKoskinen
Copy link
Contributor

Haven't really looked into this yet. The current object-cache has had some problems but they were mostly to do with the sites code. Also note that Seravo-Plugin parses the redis-cli info output so it would need a rewrite too.

Will do some comparing later but there should be a real benefit for the change.

@szepeviktor
Copy link
Author

real benefit

The benefit is sustainability.

@JoosuaKoskinen
Copy link
Contributor

Till Krüss's object-cache has improved a lot lately and I don't think changing the object-cache is a good idea. There's no performance difference, we don't have any problems with the Till Krüss's object-cache anymore and the change could introduce new issues. Closing for now! We might look in to change in the general Redis improvements issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants