Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sereal 4.006 does not export read_sereal and decode_sereal in contrast to the documentation #197

Closed
ppisar opened this issue Apr 9, 2019 · 3 comments

Comments

@ppisar
Copy link
Contributor

ppisar commented Apr 9, 2019

Sereal 4.006 stopped exporting read_sereal and decode_sereal symbols although it still documents them in the POD:

=head1 NAME

Sereal - Fast, compact, powerful binary (de-)serialization

=head1 SYNOPSIS

    use Sereal qw(
      get_sereal_decoder
      get_sereal_encoder
      clear_sereal_object_cache
      encode_sereal
      decode_sereal
      write_sereal
      read_sereal
$ perl -Ilib -e 'use Sereal qw(read_sereal);'
"read_sereal" is not exported by the Sereal module
Can't continue after import errors at -e line 1.
BEGIN failed--compilation aborted at -e line 1.

This used to work in 4.005:

[test@fedora-31 Sereal-4.005]$ perl -Ilib -e 'use Sereal qw(read_sereal);'

Is the removal of the export intentional? If it is, the documentation should be updated. By the way, this is an API breaking change and it should be properly documented in the Changes file that's missing any entry for 4.006.

@ppisar ppisar changed the title Sereal 4.006 does not export read_sereal and decode_sereal in costrast to the documentation Sereal 4.006 does not export read_sereal and decode_sereal in contrast to the documentation Apr 9, 2019
@demerphq
Copy link
Member

demerphq commented Apr 9, 2019 via email

@demerphq
Copy link
Member

demerphq commented Apr 9, 2019 via email

@ppisar
Copy link
Contributor Author

ppisar commented Apr 10, 2019

I confirm 4.007 fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants