Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest NPM release (19.0.0) still errors out with Vuetify 2.0 #12

Closed
juhasev opened this issue Oct 24, 2019 · 4 comments
Closed

Latest NPM release (19.0.0) still errors out with Vuetify 2.0 #12

juhasev opened this issue Oct 24, 2019 · 4 comments

Comments

@juhasev
Copy link

juhasev commented Oct 24, 2019

Wondering if the v19.0.0 includes the compatibility update for Vuetify 2.0? I am still getting errors after upgrading. I am using Vuetify 2.0.6.

[Vue warn]: Unknown custom element: - did you register the component correctly? For recursive components, make sure to provide the "name" option.

@SeregPie
Copy link
Owner

SeregPie commented Oct 25, 2019

Looks like you are using a-la-carte.
https://vuetifyjs.com/en/customization/a-la-carte

I guess a lot of people are using treeshaking. I will need to rework a few things. You must then import the component via import VImageInput from 'vuetify-image-input/a-la-carte' in the next version.

@juhasev
Copy link
Author

juhasev commented Oct 25, 2019

No actually not, I am using the tree shaking method (which is now default). I was looking at your components and the way you render the components. Maybe it would be a good idea to switch to single page components where the interface is supposed to remain "compatible".

@SeregPie
Copy link
Owner

a-la-carte is threeshaking.

It's supported now.

import VImageInput from 'vuetify-image-input/a-la-carte';

@juhasev
Copy link
Author

juhasev commented Oct 26, 2019

Ok installed the latest version and the error for VImageInput is gone however now I get errors for more components.

[Vue warn]: Unknown custom element:
[Vue warn]: Unknown custom element:
[Vue warn]: Unknown custom element:
[Vue warn]: Unknown custom element:

All of these components are used in my application's single file templates.

While manual a-la-carte provides the same results as automatic tree shaking with Vuetify loader. It appears that Vuetify loader cannot resolved functional components automatically and I believe this is how Vuetify Image Input is written. Even if the package imports components manually I am suspecting that they will be included twice in the project increasing the bundle size (trying to research this now).

See the note about functional components below. (Recommended import is global import)

https://vuetifyjs.com/en/customization/a-la-carte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants