Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_current_git_hash breaks when using Jakt as a submodule #1490

Open
aslilac opened this issue Oct 7, 2023 · 1 comment
Open

get_current_git_hash breaks when using Jakt as a submodule #1490

aslilac opened this issue Oct 7, 2023 · 1 comment

Comments

@aslilac
Copy link

aslilac commented Oct 7, 2023

For example, say you've added Jakt as a submodule to a folder named vendor/jakt/

  • If you ls vendor/jakt/.git you'll see it's actually just a regular file, not a directory.
  • If you cat vendor/jakt/.git you'll see something like...
$ cat vendor/jakt/.git
gitdir: ../../.git/modules/Jakt

So instead of reading "../.git/HEAD", it should actually be reading "../../../.git/modules/Jakt/HEAD".

Similarly, a bit later in the function, instead of "../.git/", the path should be "../../../.git/modules/Jakt/".

@alimpfard
Copy link
Member

🤔
So either we make that function more complicated, or add a comptime way to invoke external commands and capture their outputs - I'm not a fan of either option to be honest, maybe we should just let the thing break? it won't cause any real problems besides returning a generic version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants