Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generify for other schools: Generify / Encapsulate implicit data assumptions of replacer class #64

Closed
ArchibaldBienetre opened this issue Jan 23, 2022 · 2 comments
Assignees
Labels
extend for other schools If the project will be used for more than one school, this will be an action item

Comments

@ArchibaldBienetre
Copy link
Collaborator

With the current implementation, while the rest of the code is quite generic,
org.example.csv2tex.placeholders.PlaceholderReplacerImpl makes strong assumptions about what values there are in the data.

Many of these are likely specific to the Erfurt school, e.g. levels "rot", "grün" or grades 1, 2, 3, 4 (where other German schools will go for 1, 2, 3, 4, 5, 6 and other countries have their own thing).

If we have other interested parties, we should generify this code.

@ArchibaldBienetre ArchibaldBienetre added the extend for other schools If the project will be used for more than one school, this will be an action item label Jan 23, 2022
@ArchibaldBienetre ArchibaldBienetre self-assigned this Jan 23, 2022
@ArchibaldBienetre
Copy link
Collaborator Author

Sick with CoViD as I am, I accidentally pushed this directly to the main branch 😕 🤒 🤦‍♂️
4a271fa

I may just leave it in, if the tests run through

@ArchibaldBienetre
Copy link
Collaborator Author

Fixed.

FYI @DonMischo , I'll no longer label your changes a hack, much cleaner now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extend for other schools If the project will be used for more than one school, this will be an action item
Projects
None yet
Development

No branches or pull requests

1 participant