Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.py raise NameError exception if network is offline #530

Closed
prrvchr opened this issue Jul 2, 2023 · 2 comments
Closed

http.py raise NameError exception if network is offline #530

prrvchr opened this issue Jul 2, 2023 · 2 comments

Comments

@prrvchr
Copy link
Contributor

prrvchr commented Jul 2, 2023 •
edited

Hi,

Thank for this great API.
I just noticed that an NameError occurs when the network is offline instead of the requests connection exception.
The name of the exceptions module is just missing in front of the ConnectionError exception in the http.py file
@prrvchr prrvchr changed the title http.py raise import error if network is offline http.py raise NameError exception if network is offline Jul 2, 2023
@SergeyPirogov
Copy link
Owner

@prrvchr please provide a fix or suggestion how to fix

@prrvchr
Copy link
Contributor Author

prrvchr commented Jul 23, 2023 •
edited

I make pull request

And here are the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SergeyPirogov @prrvchr