Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor issues from Qbit86 #3

Open
SergeyTeplyakov opened this issue May 27, 2015 · 0 comments
Open

Visitor issues from Qbit86 #3

SergeyTeplyakov opened this issue May 27, 2015 · 0 comments

Comments

@SergeyTeplyakov
Copy link
Owner

  1. В листинге 6.1 в методе SaveLogEntry() что-то не в порядке с веткой else. Должно быть
if (simpleLogEntry != null)
    SaveSimpleLogEntry(simpleLogEntry);
else
    throw new InvalidOperationException(...);

А лучше сделать метод «плоским», добавив returnы вместо else.

  1. Комментарий названия паттерна от Скотта Мейерса в статье «My Most Important C++ Aha! Moments...Ever»: «Then, one day, I made a fundamental realization: the Visitor Pattern has nothing to do with visitation.»

Оригинал пожеланий: http://rsdn.ru/forum/education/6052091.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant