Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deployment guide #1029

Closed
wants to merge 4 commits into from
Closed

Add a deployment guide #1029

wants to merge 4 commits into from

Conversation

anurag
Copy link

@anurag anurag commented Jun 13, 2019

This PR adds a deployment guide in response to #171.

@ghost
Copy link

ghost commented Sep 5, 2019

I don't think the guide should serve as an advertisement platform for deployment services.

The guide should be neutral, and explain a basic deployment with optional TLS and specificities for Linux / Windows / MacOS. All of that is missing, except the explicit parts for Render, which IMO are a niche use-case.

Render should have the guide on deploying Rocket applications, not the other way around.

@jebrosen
Copy link
Collaborator

I am opposed to including in the guide any content dependent on a specific deployment service, except in the presence of a prenegotiated agreement. I think linking to tutorials for several platforms or services would be okay, as long as it does not look like an endorsement of any particular platform over any other.

I would be okay with including generic examples of creating docker or other containers, uploading binaries to an external server and configuring startup with an initscript or systemd service, and so on. I would also be fine with including a section along the lines of "platforms that respect rust-toolchain files, such as Render, this or that heroku buildpack, or QuuxBar".

@jebrosen jebrosen closed this Oct 19, 2019
@anurag
Copy link
Author

anurag commented Oct 19, 2019

Makes sense. We already have a deployment guide for Rust at https://render.com/docs/deploy-rocket-rust, and we're happy to contribute a guide with standard examples that don't rely on Render.

@SergioBenitez SergioBenitez added the pr: closed This pull request was not merged label Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: closed This pull request was not merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants