Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

"Reserved Slots.txt" should be "ReservedSlots.txt" or "reserved_slots.txt" to match directory #74

Closed
PatPeter opened this issue Sep 14, 2018 · 6 comments
Assignees
Labels
Enhancement New feature or request

Comments

@PatPeter
Copy link

The naming convention for the ~/.config/SCP\ Secret\ Laboratory/ folder is either snake case as seen with config_gameplay.txt and config_remoteadmin.txt, or PascalCase with SteamIdBans.txt and IpBans.txt1. Reserved\ Slots.txt` matches the directory name, but otherwise sticks out like an eyesore in the directory listing.

~/.config/SCP Secret Laboratory$ ls
 AddBan.sh                    config_remoteadmin.txt   IpBans.txt       PrintBans.sh          SteamIdBans.txt        verkey.txt.old
 config_gameplay_backup.txt   internal                 keybinding.txt  'Reserved Slots.txt'   SteamIDWhitelist.txt
 config_gameplay.txt          IpBans1.txt              mutes.txt        ServerLogs            verkey.txt`

But most importantly, it's because spaces are a complete pain to type in Linux. We already had to force people to change dedicated_slots to reserved_slots in their configs. Smod could read from Reserved\ Slots.txt but write to ReservedSlots.txt, reserved_slots.txt, or even config_reservedslots.txt (to match other configuration files) for backwards compatibility, and then eventually make the switch to the new file.

@ButterscotchV ButterscotchV added the Enhancement New feature or request label Sep 17, 2018
@ButterscotchV ButterscotchV self-assigned this Sep 17, 2018
@PatPeter
Copy link
Author

This is a good example of a hiccup caused by the space. It makes creating programming tools around the config folder more difficult.

https://stackoverflow.com/questions/52508887/how-do-i-define-a-gitattributes-rule-for-a-file-with-spaces-in-it?noredirect=1

@ButterscotchV
Copy link
Collaborator

Regarding this issue, there is a change planned for the next game version and possibly the next ServerMod version. The details are that the new name will be ReservedSlots.txt and that the file will be renamed automatically if the user has not directly set the name to Reserved Slots.txt in the config settings.

@KarlOfDuty
Copy link
Member

Maybe even make the configs .yml files? I want dat automatic syntax highlighting.

@ButterscotchV
Copy link
Collaborator

Reserved Slots config won't be .yml btw, I also won't be changing the other configs, those might change in the future but that's very unlikely.

@ButterscotchV
Copy link
Collaborator

Done for main game and ServerMod, whichever updates next will have this change.

@PatPeter
Copy link
Author

Thank you so much!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants