JAV-14 Updated Coverage Configuration #11
Conversation
.travis.yml
Outdated
| go: | ||
| - 1.7.3 | ||
|
|
||
| before_install: | ||
| - export HostIP="192.168.12.50" |
There was a problem hiding this comment.
Why do we need export this IP address?
There was a problem hiding this comment.
etcd will be running on this internal ip address and service-center will be connect with etcd using this ip
.travis.yml
Outdated
| - cp etc/conf/app.conf common/cron/conf/app.conf | ||
| - cd common/cron | ||
| - ginkgo -r -v -cover -coverprofile=cron.coverprofile ./... | ||
| - $HOME/gopath/bin/goveralls -coverprofile=cron.coverprofile -service=travis-ci -repotoken O04ikci0NXVZLDXJinpl79tcQvoenip2C |
There was a problem hiding this comment.
We may need to use the environment variable to store the token.
README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| # service-center [](https://travis-ci.org/ServiceComb/service-center) | |||
| # service-center [](https://travis-ci.org/ServiceComb/service-center) [](https://coveralls.io/github/asifhuawei/service-center?branch=master) | |||
There was a problem hiding this comment.
please leave this file out of the commit
| @@ -29,59 +29,59 @@ var _ = Describe("Cron", func() { | |||
| It("Test every second cron", func() { | |||
| job := Every(1).Seconds() | |||
| job.Do(DummyTask) | |||
| Expect(job.String()).To(Equal("[JOB]type: 1(seconds), interval: 1, delay: 0, at: , task: servicecenter/common/cron_test.DummyTask")) | |||
| Expect(job.String()).To(ContainSubstring("[JOB]type: 1(seconds), interval: 1, delay: 0, at: ,")) | |||
There was a problem hiding this comment.
This testcase specifically checks the job name and job name is decided by the path from which the code is running, the path can change for the forked branches so to make it generic this change was made.
|
Changes Unknown when pulling 3de17c4 on asifhuawei:latest into ** on ServiceComb:master**. |
|
Changes Unknown when pulling 6f22c3d on asifhuawei:latest into ** on ServiceComb:master**. |
|
Changes Unknown when pulling 4ef0b20 on asifhuawei:latest into ** on ServiceComb:master**. |
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage ? 49.56%
=========================================
Files ? 6
Lines ? 458
Branches ? 0
=========================================
Hits ? 227
Misses ? 215
Partials ? 16Continue to review full report at Codecov.
|
Fix Table issue in README.md and README-ZH.md
Updated the UT configuration for Service Center
Note: After this pull requests is merged please enable the service-center project in https://coveralls.io and change the link in the Readme.md