This is not inspired by go-micro

[asim]

This is not inspired by go-micro. It's literally lifting and shifting code. I can see my actual code everywhere. Maybe come discuss how you can leverage go-micro rather than just taking code.

[tianxiaoliang]

Hi Asim, I agree about leveraging go-micro rather than just taking code. But when I talking about inspiration, I mean the micro interface design and plugin thinking, they are great, appreciate those,
we already change a lot of implementation of micro component like selector or changed the interface. So how about this, we have 2 folders "vendor" is for those lib we never changed and "thirt_party" is for lib we made some changes, we will put all go-micro code in there, after this you can review our code again to see if we properly deal with your code

regards

[tianxiaoliang]

https://github.com/ServiceComb/go-chassis/tree/master/core/client/client.go
https://github.com/ServiceComb/go-chassis/tree/master/core/server/server.go
https://github.com/ServiceComb/go-chassis/blob/master/core/transport/transport.go
https://github.com/ServiceComb/go-chassis/tree/master/core/loadbalance/default.go
https://github.com/ServiceComb/go-chassis/tree/master/core/loadbalance/selector.go
https://github.com/ServiceComb/go-chassis/tree/master/core/loadbalance/filter.go
https://github.com/ServiceComb/go-chassis/blob/master/core/loadbalance/strategy.go
https://github.com/ServiceComb/go-chassis/blob/master/core/loadbalance/options.go

that is all of files which come from micro, I will move them to third_party folder

[tianxiaoliang]

Hi Asim, I have changed the code, please check again, did I do well? thanks. M truly sorry about not moving those files to third_party folder, my mistake

[asim]

There are many other places where you've just lifted code with no license reference. You do realise all micro projects are under the apache 2 license which means you must give credit where code is taken from there even when modified after.

The tcp transport
Yours: https://github.com/ServiceComb/go-chassis/blob/master/transport/tcp/tcp.go
Micro: https://github.com/micro/go-plugins/blob/master/transport/tcp/tcp.go

[asim]

The other point is. Is this an official huawei project or something separate? I would not expect this kind of behaviour from a company.

[tianxiaoliang]

It’s my first time to work with Go open source project. I admit I made some mistakes. Could you provide some advices for leveraging the go-micro in a better way? Current we have a different registry model which could be difficult for us to leverage go-micro code directly, maybe we can discuss some details about it later.

[tianxiaoliang]

Thanks for pointing that out, go-micro is a great framework, which I learned lot of thing there. I'm really appreciate your work.
Can you give me your email, thus we can do further disscussion in email, thanks very much.

[asim]

I don't feel the need to discuss this in any other forum except a public one here so everyone can see.

Is this an official huawei project?

[WillemJiang]

The license and copyright of go-micro had been included at the initial commit of the go chassis here[1].
And now the copyright of go-micro has been added to the notice file in the ROOT directory.

[1] https://github.com/ServiceComb/go-chassis/blob/master/third_party/forked/go-micro/LICENSE

[asim]

Thank you for doing that. Although you still have not answered my question. Is this an official huawei project?

Including a license in third_party does not account for copying the code in other places and using them as your interfaces. Where the code has been modified you must show credit to the author. I see this has since been corrected.

[asim]

Please answer my question. Is this an official huawei project?

[WillemJiang]

Hi Asim，

Thanks for helping us correct the License issue to honor copyright of the original author. The go-chassis is currently a general open source project under Github but we do have plan to merge it into Apache ServiceComb (incubating), which is donated by Huawei. Is this going to be a problem for you? I'm not quite sure what your mean on Huawei official project. Can you give me some of your definition on this?

I‘m quite impressed by the pluggable design of go-micro. go-chassis uses go-micro's client, server, selector, codec and transport modules to get the pluggability, but go-chassis has some other advanced services governance features, such as fault tolerance, circuit breaker, load balancing, monitoring, hot reconfiguration.

Anyway, it would be fantastic if we could leverage go-micro and also contribute some of changes back to the upstream, and I am very open to any of this kind of discussion.

[asim]

I'm not quite sure what your mean on Huawei official project

Basically what I'm saying is, are you working on this at Huawei. Is this effort being funded by Huawei. Is it being done on company time. Which in essence makes it an official project.

go-chassis has some other advanced services governance features, such as fault tolerance, circuit breaker, load balancing, monitoring, hot reconfiguration.

These are concerns micro addresses in different ways. We have a middleware interface known as wrappers which let's extra functionality be added https://github.com/micro/go-plugins/tree/master/wrapper. Further efforts were also made in go-os but requires a team of developers to drive forward https://github.com/micro/go-os

Anyway, it would be fantastic if we could leverage go-micro and also contribute some of changes back to the upstream, and I am very open to any of this kind of discussion.

Contribution is welcome. Plugins are maintained in go-plugins https://github.com/micro/go-plugins. If you're building higher level functionality as you say then it appears as part of the ecosystem https://micro.mu/explore/.

If this is an official Huawei project then it would be interesting to partner much like we've done with Sixt.

[WillemJiang]

Thanks for your great suggestions. As an open source developer, it's a common practices that several projects work together as a community. But it may take some time to build up the business partnership, maybe we can talk about it in another thread later.

[itechbear]

I believe it is an official project. Many BIG Chinese companies (oops,I'm from China too), like Huawei, Xiaomi, etc, don't take "Open Source" serious. It's common for them to steal source code from Open Source projects. Anyway, Huawei is doing better on this project, at least they let you know that.

[llllll00700]

看着都脸红

[RainingNight]

any news ? :)

[OrangeHao]

They don't know what is the meaning of license.A big company,kidding me

[tianhe2018]

昨晚被刷屏了， 作为一个吃瓜群众， 引用一句话来形容这件事情

《孔乙已》“窃书不能算偷……窃书！……读书人的事，能算偷么？

[DuLerWeil]

至少是华为员工挂以华为名义推出的项目。但是在此问题上，普通员工不敢贸然代表公司承认，能采取的措施就是能改则改、回避问题以及避重就轻。关注后续是公司出面道歉，还是临时工替罪背锅了，无奈。

[zyt12345]

KPI惹的祸

[CaoShuFeng]

华为对开源的贡献有目共睹。
至少这个东西也是开源的， 作者也在积极补救。

[choleraehyq]

Why don't you Huawei guys use go-micro/fasthttp/hystrix-go as dependencies rather than copying them into a meaningless third_party directory?

[CaoShuFeng]

Including a license in third_party does not account for copying the code in other places and using them as your interfaces. Where the code has been modified you must show credit to the author. I see this has since been corrected.

If all asim's comments have been addressed and the mistake has been corrected, should we close this issue?

[xionghengheng]

被怼了。。。

[tanzhongyi003]

mark

[zhibuzu]

m

[meggarr]

Comments from Chinese news

2017年6月19日在 LC3 开源峰会上，华为宣布开源了微服务框架 ServiceComb，华为称它是 FusionCloud 解决方案中 PaaS 平台的重要组成部分，内置了高可靠性运行、动态治理等运维阶段的高级能力。

Translated by Google

June 19, 2017 At the LC3 Open Source Summit, Huawei announced ServiceComb, an open-source microservice framework. Huawei claims that it is an important part of the PaaS platform in FusionCloud. It has built-in operation and maintenance phases such as high-reliability operation and dynamic management Advanced ability.

So what do you think when you are asking Is this an official huawei project ... ? @asim

[FrontMage]

This would never be a Huawei official project as long as it does any damage to the company's reputation.
It's pointless to argue, because most Chinese just do not care.
While the crowd has very short memory, this scandal would just be overwhelmed by some other gosip news.

---

If Huawei do really care, just admit it and correct it, there is no need to cover up.
Anyone would make mistakes, even Apple and Google, and they just say sorry and correct it.

[CaoShuFeng]

http://www.apache.org/foundation/license-faq.html#Distribute-changes

This document said:

You can give your modified code away for free, or sell it, or keep it to yourself, or whatever you like.

So selling Apache License 2.0 licensed open source software is not illegal behavior.

It also said:

You may distribute the result under a different license, but you need to acknowledge the use of the Foundation's software. To do otherwise would be stealing.

Redistribution without acknowledging the use of the Foundation's software is stealing.
The license of go-micro has been included in this project. So I think the mistake has been corrected.

[asim]

I am satisfied that the authors of this library have corrected the issue by including licenses and moving code to a third party directory. I would however ask for a few things.

1. Please contribute back plugins to go-plugins to help the community benefit
2. Allow the Huawei logo to be used on the website to acknowledge it as a user
3. Start a discussion around a partnership to support go-micro development

Thanks to everyone else who has commented and supported go-micro. I am one person building open source and the support means a lot. Large companies should support the development of OSS considering it's at the core of their technology.

[JackEggie]

feel so shame as a Chinese developer. I believe that most of us never take the Licence serious, even we contribute so much code at Github.com.

We should respect more to those authors who help us to complete our work and the Open Source Community.

[leaxoy]

mark

[PerfectForNi]

Apache License 2.0 Conditions

• A copy of the license and copyright notice must be included with the software.
• Changes made to the code must be documented.

[narry]

mark

[Viyond]

We should respect more to those authors who help us to complete our work and the Open Source Community.

[itfanr]

mark

[Leon2012]

mark

[asim]

This PR attempts to remove license references to go-micro #151

Your works are based on go-micro, even after modification and elimination of go-micro code they are still based on it and with that you cannot remove the license. I can still point to parts of your code that look like go-micro.

[mdh67899]

mark

[khadgarmage]

mark

[eccozhou]

mark

[earyantLe]

mark

[bryanpkc]

PSA: Please learn to use the Subscribe button and stop spamming people with these meaningless "mark" messages.

[winnoryder]

mark

[MondayWoo]

shame on it

[tianxiaoliang]

Aggree with #28 (comment)

Lock the issue to stop spamming people with these meaningless "mark".

[tianxiaoliang]

http://www.apache.org/foundation/license-faq.html#Distribute-changes

This document said:

You can give your modified code away for free, or sell it, or keep it to yourself, or whatever you like.

So selling Apache License 2.0 licensed open source software is not illegal behavior.

It also said:

You may distribute the result under a different license, but you need to acknowledge the use of the Foundation's software. To do otherwise would be stealing.

Redistribution without acknowledging the use of the Foundation's software is stealing.
The license of go-micro has been included in this project. So I think the mistake has been corrected.

will close this issue