Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-environment #115

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Support multi-environment #115

merged 1 commit into from
Mar 14, 2018

Conversation

humingcheng
Copy link
Collaborator

No description provided.

@humingcheng humingcheng force-pushed the master branch 2 times, most recently from 4304715 to 0500115 Compare March 13, 2018 01:10
tianxiaoliang
tianxiaoliang requested changes Mar 13, 2018
View reviewed changes
Copy link
Member

@tianxiaoliang tianxiaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FindMicroServiceInstances also need to extend new input "env"

@coveralls
Copy link

coveralls commented Mar 13, 2018 •
edited

Coverage Status

Coverage decreased (-0.04%) to 65.912% when pulling e0f147d on humingcheng:master into ee0cb87 on ServiceComb:master.

@tianxiaoliang tianxiaoliang merged commit f310f57 into go-chassis:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianxiaoliang tianxiaoliang tianxiaoliang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@humingcheng @coveralls @tianxiaoliang