-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loadbalance session stickiness support for Highway Protocol #147
Merged
tianxiaoliang
merged 2 commits into
go-chassis:master
from
joseph-v:LBsessionstickinessupdate
Mar 29, 2018
Merged
Add loadbalance session stickiness support for Highway Protocol #147
tianxiaoliang
merged 2 commits into
go-chassis:master
from
joseph-v:LBsessionstickinessupdate
Mar 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@joseph-v there are still go-lint issues
|
joseph-v
force-pushed
the
LBsessionstickinessupdate
branch
from
March 28, 2018 05:37
da3b8d7
to
fa5a691
Compare
joseph-v
force-pushed
the
LBsessionstickinessupdate
branch
from
March 28, 2018 05:49
fa5a691
to
447d1c3
Compare
tianxiaoliang
requested changes
Mar 28, 2018
core/handler/transport_handler.go
Outdated
session.CheckForSessionID(inv.Endpoint, config.GetSessionTimeout(inv.SourceMicroService, inv.MicroServiceName), reply.GetResponse(), req.GetRequest()) | ||
} | ||
case common.ProtocolHighway: | ||
inv.Ctx = session.CheckForSessionIDHighway(inv.Ctx, inv.Endpoint, config.GetSessionTimeout(inv.SourceMicroService, inv.MicroServiceName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename CheckForSessionIDHighway to CheckForSessionIDFromContext
req := req.Arg.(*rest.Request) | ||
session.CheckForSessionID(inv.Endpoint, config.GetSessionTimeout(inv.SourceMicroService, inv.MicroServiceName), reply.GetResponse(), req.GetRequest()) | ||
} | ||
case common.ProtocolHighway: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default:
joseph-v
force-pushed
the
LBsessionstickinessupdate
branch
from
March 28, 2018 06:46
53399c6
to
375405e
Compare
joseph-v
force-pushed
the
LBsessionstickinessupdate
branch
from
March 28, 2018 11:12
375405e
to
ac3c35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.