Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust license&notice #151

Closed
wants to merge 1 commit into from
Closed

Conversation

wangkirin
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 62.838% when pulling 8379862 on wangkirin:notice_license into 1e3a4af on ServiceComb:master.

@yangbor
Copy link

yangbor commented Apr 8, 2018

  1. Third party NOTICE files should be included(prometheus)
  2. There's no need to keep a separate copy of apache 2.0 license for third party libraries

@asim
Copy link

asim commented Apr 8, 2018

Can you actually remove licenses when your original works were based on them? What you are left with is modified code. You cannot strip references just because you now no longer fork the code.

@zhanbei
Copy link

zhanbei commented Apr 10, 2018

According to https://blog.github.com/2015-01-21-how-to-write-the-perfect-pull-request/ , I suppose by "adjust license&notice" you mean what this Pull Request does but not the purpose of this PR which is expected.

Include the purpose of this Pull Request. For example:

This is a spike to explore…
This simplifies the display of…
This fixes handling of…

This comment is just a suggestion that I would like to point out and I hope it didn't bother you. Thanks.

@wangkirin
Copy link
Contributor Author

Thanks for all the reviews and suggestions, I will reconsider this PR

@wangkirin wangkirin closed this Apr 10, 2018
@wangkirin wangkirin deleted the notice_license branch April 10, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants