add kube registry and examples #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninokop
force-pushed
the
master
branch
2 times, most recently
from
a3cf655
to
1ddc810
Compare
core/config/model/registry.go
Outdated
| @@ -18,6 +18,7 @@ type RegistryStruct struct { | |||
| Tenant string `yaml:"tenant"` | |||
| AutoRegister string `yaml:"register"` | |||
| APIVersion RegistryAPIVersionStruct `yaml:"api"` | |||
| ConfigPath string `yaml:"configPath"` | |||
There was a problem hiding this comment.
registry is deprecated, do not maintain, you can add this comment at the top
|
provide the doc |
|
need UT for kube controller |
tianxiaoliang
requested changes
Jul 11, 2018
core/registry/index.go
Outdated
| @@ -137,3 +137,18 @@ func (m *MicroServiceInstance) WithAppID(v string) *MicroServiceInstance { | |||
| m.Metadata[common.BuildinTagApp] = v | |||
| return m | |||
| } | |||
|
|
|||
| // GetEndPointByProto get endpoint by protocol | |||
| func (m *MicroServiceInstance) GetEndPointByProto(proto string) (string, bool) { | |||
There was a problem hiding this comment.
limit user k8s service port name naming convention, not use code to handle complicated scenario
ninokop
force-pushed
the
master
branch
4 times, most recently
from
493b4aa
to
1807509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.