Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema modify rule by service env #195

Merged
merged 3 commits into from Dec 6, 2017
Merged

schema modify rule by service env #195

merged 3 commits into from Dec 6, 2017

Conversation

aseTo2016
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 70.778% when pulling 89905cd on aseTo2016:aseTo2016 into 6dc59fa on ServiceComb:master.

@@ -80,22 +78,22 @@ func (s *MicroServiceService) GetSchemaInfo(ctx context.Context, in *pb.GetSchem

func (s *MicroServiceService) DeleteSchema(ctx context.Context, request *pb.DeleteSchemaRequest) (*pb.DeleteSchemaResponse, error) {
if request == nil || len(request.ServiceId) == 0 || len(request.SchemaId) == 0 {
util.Logger().Errorf(nil, "delete schema failded: invalid params.")
util.Logger().Errorf(nil, "delete schema faild: invalid params.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faild -> failed

2、find dependency bug fix
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 70.343% when pulling d62f521 on aseTo2016:aseTo2016 into 6dc59fa on ServiceComb:master.

@little-cui little-cui merged commit 0f3a8d4 into apache:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants