Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: New API to add or update micro-service dependency. #196

Merged
merged 4 commits into from Dec 7, 2017

Conversation

little-cui
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 71.899% when pulling c403962 on little-cui:master into 0f3a8d4 on ServiceComb:master.

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #196 into master will increase coverage by 1.4%.
The diff coverage is 55.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #196     +/-   ##
=========================================
+ Coverage   66.86%   68.27%   +1.4%     
=========================================
  Files          17       17             
  Lines        3498     3521     +23     
=========================================
+ Hits         2339     2404     +65     
+ Misses       1000      955     -45     
- Partials      159      162      +3
Impacted Files Coverage Δ
server/service/microservices.go 73.03% <100%> (ø) ⬆️
server/service/util/microservice_util.go 77.59% <100%> (ø) ⬆️
server/service/util/dependency.go 50.13% <40%> (+5.83%) ⬆️
server/service/service_dependency.go 76.52% <90%> (+8.72%) ⬆️
server/service/instances.go 71.21% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3a8d4...495d6d8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.6%) to 71.899% when pulling 495d6d8 on little-cui:master into 0f3a8d4 on ServiceComb:master.

@little-cui little-cui merged commit 2288562 into apache:master Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants