Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URLs to docs #152

Closed
JosephMarinier opened this issue Jun 17, 2022 · 5 comments
Closed

Fix URLs to docs #152

JosephMarinier opened this issue Jun 17, 2022 · 5 comments
Assignees
@JosephMarinier @Dref360
Labels
bug Something isn't working
Milestone
Continuous

Comments

@JosephMarinier
Copy link
Contributor

This is following the versioning of our documentation.

URLs without the version (for example https://servicenow.github.io/azimuth/getting-started that is linked in the README) still exist and seem to point to an older version (not main). I can imagine a couple of options:

  1. Those URLs could redirect to /main/... ?
  2. Those URLs could be the "main" ones? Replacing /main/...
  3. Those URLs could die? And we make sure we convert all the links to them.
@JosephMarinier JosephMarinier added the bug Something isn't working label Jun 17, 2022
@JosephMarinier JosephMarinier self-assigned this Jun 17, 2022
@JosephMarinier
Copy link
Contributor Author

Option 1 with 5484db5 and deleting all the files from the "root" version of the docs.

@Dref360
Copy link
Contributor

Dref360 commented Jun 20, 2022

When I click on v2.1, the versioning disappear.
https://servicenow.github.io/azimuth/v2.1/

@JosephMarinier
Copy link
Contributor Author

Right, I noticed that, but I don't know if it has anything to do with the "root" version that we modified.

@JosephMarinier
Copy link
Contributor Author

I reopened the issue since I found a bug with my current implementation is that if you visit /main/potato, you get redirected to /main/main/potato, then to /main/main/main/potato and so on and so forth.

@JosephMarinier
Copy link
Contributor Author

I think the original issue is fixed now. I opened a new issue #154 for the second bug you pointed out.

@gabegma gabegma added this to the Continuous milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JosephMarinier JosephMarinier

@Dref360 Dref360

Labels
bug Something isn't working
Projects
Azimuth
Archived in project
Milestone
Continuous
Development

No branches or pull requests
3 participants
@JosephMarinier @Dref360 @gabegma