Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement limits of menu nesting #1

Closed
MGOPW opened this issue Sep 28, 2023 · 1 comment · Fixed by #23
Closed

Implement limits of menu nesting #1

MGOPW opened this issue Sep 28, 2023 · 1 comment · Fixed by #23
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MGOPW
Copy link
Collaborator

MGOPW commented Sep 28, 2023

I've tried to reverse-engineer these as best as I could to make this component, but I know I haven't fully figured it out yet. Here's what I already know to help you get started.

Menus have a complex parent/child relationship that determines their behavior and how menus are presented. For example, the more menus you have nested, their appearance and layout changes in the menu itself. I think the limit of nesting is 4 menus deep, but i'm not sure.

Actions have similar behavior, which I haven't cataloged. Sometimes they show up as buttons, while other times they show up as links.

The purpose of this issue is to investigate the behaviors and add guard rails to the component so you can't add more menus or actions than what works in the instance. Right now you can add as many menus and actions as you want in our component, but the menu will not render at all when being tested if it doesn't follow the hidden guidelines.

@MGOPW
Copy link
Collaborator Author

MGOPW commented Oct 1, 2023

#12 created to handle the visual preview aspect of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
1 participant