Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #34

Open
Sesu8642 opened this issue Oct 23, 2022 · 0 comments
Open

Refactoring #34

Sesu8642 opened this issue Oct 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Sesu8642
Copy link
Owner

Sesu8642 commented Oct 23, 2022

Here are some things that I would like to refactor at some point:

  • the UI, especially the ingame screen hast too much logic which should go somewhere else, e.g. determining whether the winner changed during a bot turn
  • texts should be in some resource file (translatable later)
  • the complexity of some methods is way too high and they should be split up
  • autosaving needs be more efficient and save less data (there are performance problems on huge maps)
  • the event bus is a little overused which causes very (too) loose coupling at some places
    • the loose coupling makes sense between frontend and backend as well as internally in the UI
  • there should be way more unit tests
  • visibility of many classes and methods is too high
    • could be limited to package but I like to use packages for organizing the structure too much
    • maybe Java 9 modules could help but the project is stuck with 8 for now
  • json serialization/deserialization using the libGDX API is tedious and relies on hardcoded package names
    • better use Jackson or Gson as GWT compatibility is no longer relevant
@Sesu8642 Sesu8642 added the enhancement New feature or request label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant