You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several things have been raised by the #60 review that should be addressed in subsequent PRs
Service is can easily fail if one of the (many) external resource calls fails
Gas price oracles
Use fallbacks? e.g gasNow and EthGasStation ?
CoinGecko token list: especially bad for polygon which makes 4 external calls to compose a list.
(from review) In a follow up, we should make this fault tolerant to CoinGecko API failures, return default values for things like estimated USD value, and return some kind of error that indicates CoinGecko failed.
Pricing seems pretty time sensitive... perhaps we can have redundancy via another service?
Could also maintain our own token list (for metadata) and generate in a CI chron job / publish to github?
Several things have been raised by the #60 review that should be addressed in subsequent PRs
Resolved in #60
Add a separate flow for an indicative vs firm 0x quotes (Tracking in Add flows for indicative vs. firm quotes in TradeQuoter #63)
/swap/v1/price
/swap/v1/quote
(removeintentOnFilling
logic?)Currency/price formatting
The text was updated successfully, but these errors were encountered: