Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upPHP 7.1 compatibility #9
Comments
This comment has been minimized.
This comment has been minimized.
I just executed our internal tests against PHP 7.1.0RC1 and previous beta3 release and both went through. Could you please verify that all related classes are up to date? |
This comment has been minimized.
This comment has been minimized.
Simey, as we are not able to reproduce this, could you offer more details on that issue? |
This comment has been minimized.
This comment has been minimized.
Hi, we are still trying to figure out why we are getting errors...have you checked your error.log to see if there's any error there? Something like callling non-static methods statically? |
This comment has been minimized.
This comment has been minimized.
Tests ran with E_ALL. Again: Please verify that ALL related classes are up to date. |
This comment has been minimized.
This comment has been minimized.
Hello Jan, we are investigating why we are having a failure in moodle - see https://tracker.moodle.org/browse/MDL-55848 |
This comment has been minimized.
This comment has been minimized.
That behaviour is very strange. It would mean that fpdi_bridge would never extend TCPDF but a call of is_subclass_of($this, 'TCPDF') would return true? I guess you should report this, after some more validation, on https://bugs.php.net/ |
This comment has been minimized.
This comment has been minimized.
yes, I don't believe this is a bug in FPDI. If it won't resolve itself in RC2 or stable release of php7.1 we'll have to patch the library included in moodle in order to hide this error. We already have another report of opcache messing with class definitions and it's hard to report to php because we can't provide reliable reproduction steps. Thank you for the prompt reply and your help. Feel free to close this issue and, if you are interested, follow bug in our tracker. |
This comment has been minimized.
This comment has been minimized.
Ok, perfect, thanks for reporting anyway! |
Hi, we currently use this library on moodle core.
Doing some compatibility tests on the new php version (7.1) we noticed a error on this line.
_Exception - Call to undefined method FPDF_TPL::prepareValue()
Apparently there were some changes on the way php handles inheritance, probably that's why this works fine on PHP7 but not on 7.1