Fast Numbers on its own isinstance()

[ragardner]

I am not sure if it's worth looking into because when importing fastnumbers by simply stating: import fastnumbers An error does not occur, but...

This code causes an error (Python 3.63 windows 10 64bit):

from fastnumbers import *

x = 1

if isinstance(x,int):
    print ("it's an integer")

the error is:

if isinstance(x,int):
TypeError: isinstance() arg 2 must be a type or tuple of types

[SethMMorton]

This is a known issue. I tried to highlight this in the API:

Behaves identically to the built-in int except for the following:

• Is implemented as a function, not a class, which means it cannot be sub-classed, and has no from_bytes classmethod.

I suppose I did not call out that isinstance would also not work. Do you think it would be worthwhile to make this more clear?

[ragardner]

Ah yeah, I should have spent more time reading the guide as opposed to skimming through it, sorry, it's clear to me now why isinstance() wouldn't work with the drop in int().

For people new to programming they might not know, but I guess if you have any knowledge of classes it's quite clear.

I was also previously unaware that import fastnumbers did not import the drop in replacements, I think this is the right behavior though as people might not want them especially when they already have access to the fast conversions etc