Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "key" option to "on_fail" #32

Closed
SethMMorton opened this issue Nov 13, 2019 · 0 comments · Fixed by #34
Closed

Rename "key" option to "on_fail" #32

SethMMorton opened this issue Nov 13, 2019 · 0 comments · Fixed by #34
Assignees
Milestone

Comments

@SethMMorton
Copy link
Owner

The key option to the fast_* functions is intended to be executed when the input cannot be converted. key is usually something that is executed before the algorithm, not after, so this name has always been a bother. I think on_fail is more descriptive of when the function is executed.

key will remain valid but deprecated/discouraged. If both key and on_fail are given, an error will be raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant