Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing -lm breaks build on armv7hl #53

Closed
pterjan opened this issue Feb 27, 2022 · 0 comments · Fixed by #54
Closed

Missing -lm breaks build on armv7hl #53

pterjan opened this issue Feb 27, 2022 · 0 comments · Fixed by #54

Comments

@pterjan
Copy link
Contributor

pterjan commented Feb 27, 2022

Describe the bug
Build failure on armv7hl

/usr/bin/ld: build/temp.linux-armv8l-3.10/src/numbers.o: in function `_PyFloat_is_Intlike':
/home/iurt/rpmbuild/BUILD/fastnumbers-3.2.1/src/numbers.c:69: undefined reference to `floor'

As the code uses floor() it should set -lm when linking. I guess on other architectures something else is already pulling in -lm so it was not noticed.

Adding extra_link_args=["-lm"]to setup.py fixes it.

Environment (please complete the following information):

  • fastnumbers version: 3.2.1
  • Python Version: 3.10
  • OS: Mageia
  • Compiler (if known): gcc 11.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant