Fix sorting in ce locale #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that going forward this won't not sort correctly.
For some locales, the unicode cannot be decomposed otherwise the ordering is incorrect.
SethMMorton
force-pushed
the
fix-sorting-in-ce-locale
branch
from
922b15b
to
a911826
Compare
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 96.57% 96.60% +0.02%
==========================================
Files 10 10
Lines 613 618 +5
==========================================
+ Hits 592 597 +5
Misses 21 21
Continue to review full report at Codecov.
|
SethMMorton
force-pushed
the
fix-sorting-in-ce-locale
branch
from
9105163
to
96d46e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to close issue #140.