Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat paths as strings in StrParser #153

Merged
merged 4 commits into from
Aug 29, 2022
Merged

Conversation

Gilthans
Copy link
Contributor

As discussed in #152

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Base: 96.62% // Head: 92.62% // Decreases project coverage by -3.99% ⚠️

Coverage data is based on head (e4f8cd2) compared to base (e3c32f5).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   96.62%   92.62%   -4.00%     
==========================================
  Files          10       10              
  Lines         622      624       +2     
==========================================
- Hits          601      578      -23     
- Misses         21       46      +25     
Impacted Files Coverage Δ
natsort/compat/locale.py 63.82% <60.00%> (-31.92%) ⬇️
natsort/utils.py 98.39% <100.00%> (+0.01%) ⬆️
natsort/compat/fastnumbers.py 57.14% <0.00%> (-35.72%) ⬇️
natsort/natsort.py 87.07% <0.00%> (-3.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gilthans
Copy link
Contributor Author

There is a mypy failure which seems unrelated to the change, not sure if this was passing beforehand?

@SethMMorton
Copy link
Owner

Ugh - that is likely due to an update in mypy.

Want to take a stab? I think it could be solved with an if statement... it's because getlocale() can return (None, None) if the locale is "C".

@Gilthans
Copy link
Contributor Author

Fixed (hope it's OK in the same PR).
Locally mypy was complaining about a bunch of other things as well, so I wasn't able to see it green locally, not sure why the CI is ok with those.
The errors in the CI did go away though

@Gilthans
Copy link
Contributor Author

Friendly ping - would love to see this fix upstream!

@SethMMorton SethMMorton merged commit e5d2e45 into SethMMorton:master Aug 29, 2022
@SethMMorton
Copy link
Owner

Released with 8.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants