-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat paths as strings in StrParser #153
Conversation
Codecov ReportBase: 96.62% // Head: 92.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 96.62% 92.62% -4.00%
==========================================
Files 10 10
Lines 622 624 +2
==========================================
- Hits 601 578 -23
- Misses 21 46 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There is a mypy failure which seems unrelated to the change, not sure if this was passing beforehand? |
Ugh - that is likely due to an update in Want to take a stab? I think it could be solved with an if statement... it's because |
Fixed (hope it's OK in the same PR). |
Friendly ping - would love to see this fix upstream! |
Released with 8.2.0. |
As discussed in #152