Make typing less strict #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethMMorton
force-pushed
the
make-typing-less-strict
branch
from
6406baf
to
9a964fd
Compare
...and to some degree private as well. Previously, the declared hints for natsort were too restrictive. Generics and protocols are now utilized to make the type hints more "open" which is more realistic, since more than just basic types can be sorted.
This way we don't need to use casts in-code.
SethMMorton
force-pushed
the
make-typing-less-strict
branch
from
9a964fd
to
ffda841
Compare
Codecov ReportBase: 96.79% // Head: 98.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 96.79% 98.44% +1.64%
==========================================
Files 10 10
Lines 624 578 -46
==========================================
- Hits 604 569 -35
+ Misses 20 9 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #154.
This MR aims to make
natsortfunctions accept a wider variety of types when type-checking, which is more reflective of reality.