Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronExpressionType: new Exceptions for dbal4 #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jun 4, 2024

Closes #42

I'm unsure about if the second exception is more InvalidFormat, but these one wants an $expectedFormat and I don't think that works for this

@Hanmac
Copy link
Contributor Author

Hanmac commented Jun 4, 2024

@loevgaard do you know how to please the psalm?

@Hanmac
Copy link
Contributor Author

Hanmac commented Jun 4, 2024

@loevgaard also "Code Coverage" doesn't seem to work on the Pull Requests anymore?

Because I'm pretty sure it is not going to like the return null at the end of this: (this case should not apply because it should be either one or the other)

            if (class_exists(InvalidType::class)) {
                throw InvalidType::new($value, CronExpression::class, ['string']);
            } else if (method_exists(ConversionException::class, "conversionFailedInvalidType")) {
                throw ConversionException::conversionFailedInvalidType($value, CronExpression::class, ['string']);
            }
            return null;

@Hanmac
Copy link
Contributor Author

Hanmac commented Jun 5, 2024

@loevgaard is it okay to ignore the psalm issues, or would there be a better way?

@Hanmac
Copy link
Contributor Author

Hanmac commented Jun 17, 2024

@loevgaard can you look at this so my projects can be updated to dbal4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Upcoming Doctrine/Dbal 4.0
1 participant