Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buying of gift cards with gift cards #236

Open
markbeazley opened this issue Jul 27, 2022 · 1 comment
Open

Disable buying of gift cards with gift cards #236

markbeazley opened this issue Jul 27, 2022 · 1 comment

Comments

@markbeazley
Copy link

At the moment it seems that it is kind of possible to order a gift card with another gift card, the customer can complete the checkout process and the old card is shown as used, but as the order has no payment it seems it doesn't enable the new card. This could allow for a user to refresh a gift card that is due to expire, although it would require an admin/staff user to manually enable to new card, its still not the best user experience. I can think of two possible solutions:

  1. Catch this at the point the user tires to add the gift cart, and reject applying the card if their cart contains a gift card, then anytime the cart is updated remove any applied gift cards from teh order if the cart now contains a gift card.
  2. Don't include the cost of gift cards when calculation the cost to use from the gift card, this would allow the customer to buy a new gift card and buy non gift card products in the same order whilst allowing them to use another gift card to pay for the non gift card products.

I think 2 might be the better solution, especially if it included a message/alert explaining that gift cards can't be used against gift cards.

@loevgaard
Copy link
Member

Oftentimes the simplest solution proves to be the best solution. Could you make a PR for option 1? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants