Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory intensive repository method, findEnabled #238

Open
loevgaard opened this issue Nov 14, 2022 · 0 comments
Open

Memory intensive repository method, findEnabled #238

loevgaard opened this issue Nov 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@loevgaard
Copy link
Member

loevgaard commented Nov 14, 2022

We need to look into this method:

https://github.com/Setono/SyliusGiftCardPlugin/blob/v0.11.9/src/Doctrine/ORM/GiftCardRepository.php#L57-L62

  • where is it used?
  • what can we do to not use it?

because this would be very memory intensive for say 100,000 enabled gift cards

Probably related: #148

@loevgaard loevgaard added the enhancement New feature or request label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant