New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] SearchGiftCardAction should check _csrf_token #25

Closed

igormukhingmailcom opened this issue Nov 12, 2019 · 1 comment · Fixed by #32

Assignees

Member

igormukhingmailcom commented Nov 12, 2019

Currently, if you go to http://localhost:8000/en_US/gift-card/search?code=SOME_VALID_CODE, you will see it, but shouldn't.

_csrf_token should be checked to prevent brute-force.

The text was updated successfully, but these errors were encountered:

loevgaard mentioned this issue

Added search form #32

Merged

loevgaard closed this as completed in #32

Member Author

igormukhingmailcom commented Dec 6, 2019 •

edited

Still shows actual balance https://www.dropbox.com/s/4z1hcqml2sjzn6q/Screenshot%202019-12-06%2016.21.29.png?dl=0 even if invalid (absent) token provided (for example, via link http://localhost:8000/en_US/gift-card/search?setono_sylius_gift_card_gift_card_search%5BgiftCard%5D=EE7C242673AD43EFFD9E)

igormukhingmailcom reopened this

igormukhingmailcom self-assigned this

igormukhingmailcom mentioned this issue

[RFC] Security questions #45

Open

igormukhingmailcom closed this as completed in

8a0a597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment