Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Think about renaming findByEmailPart #77

Closed
igormukhingmailcom opened this issue Jul 21, 2020 · 1 comment · Fixed by #84
Closed

Think about renaming findByEmailPart #77

igormukhingmailcom opened this issue Jul 21, 2020 · 1 comment · Fixed by #84

Comments

@igormukhingmailcom
Copy link
Member

As AdminOrderCreation plugin have the same name at its CustomerRepositoryTrait.

Something like findByEmailPartForGiftCard (append context) or setonoFindByEmailPart (prepend vendor name).

Reasons:

  • Interfaces the same right now, but implementations still a bit different
  • Something can change at future

Related:
@chadyred
Copy link
Contributor

+1 it could be great

@loevgaard loevgaard mentioned this issue Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove inherent overlap with admin order creation plugin Setono/SyliusGiftCardPlugin
2 participants
@chadyred @igormukhingmailcom