Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to enter GiftCard code in the same input as coupon #59

Open
Roshyo opened this issue Mar 16, 2020 · 1 comment · May be fixed by #92
Open

Allow to enter GiftCard code in the same input as coupon #59

Roshyo opened this issue Mar 16, 2020 · 1 comment · May be fixed by #92
Assignees
@Roshyo
Milestone
v1.0

Comments

@Roshyo
Copy link
Contributor

Roshyo commented Mar 16, 2020

It would be useful to allow users to enter the Gift card code in the same input as regular coupon. It should also be a possibility, not the unique behavior. So we could add in admin panel a new configuration for GiftCard that would be like "Have 2 separate inputs in cart ?"

If yes : keep behavior like now
If no : Hook on "coupon application" and check whether it's a coupon (default behavior) or a Gift Card code.

We would also need to add a validator to GiftCardCode so they are never the same as coupon
@loevgaard loevgaard added this to the v1.0 milestone Aug 7, 2020
@loevgaard
Copy link
Member

loevgaard commented Aug 7, 2020 •
edited
Loading

For the first version of this feature I don't think we should have the toggle in the backend, but just as a configuration option.

@Roshyo Roshyo self-assigned this Aug 7, 2020
Roshyo added a commit that referenced this issue Aug 8, 2020
@Roshyo
Allowing to use the same input for PromotionCoupon and GiftCards
868a066 
Fixes #59
@Roshyo Roshyo linked a pull request Aug 8, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roshyo Roshyo

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Allowing to use the same input for PromotionCoupon and GiftCards Setono/SyliusGiftCardPlugin
2 participants
@loevgaard @Roshyo