Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the permanent property? #64

Open
loevgaard opened this issue Jan 2, 2021 · 3 comments
Open

Remove the permanent property? #64

loevgaard opened this issue Jan 2, 2021 · 3 comments

Comments

@loevgaard
Copy link
Member

Right now you can create two kinds of redirects: A permanent (301) and a temporary (302). My suggestion is to remove the ability to choose and instead make the 301 redirect the way to go.

I have created tons of redirects in my life during migrations of products etc. I have never in my life created a temporary redirect. Also you would never create a temporary redirect for SEO purposes. That would always be a permanent.

According the this article from Yoast a 302 redirect that is active for too long will be treated as a 301. This has the implication that in theory we should probably have an expiry date when creating a temporary (302) redirect. That will just add to the complexity of this plugin.

Removing the permanent/temporary option would also open up for this issue: #62 which in turn would lower the complexity of the plugin.

Any thoughts / feedback is very welcome.

@stefandoorn
Copy link
Contributor

I also can't remember when I used a 302 unless it's for a specific migration. So I think it makes sense to me.

@veloxy
Copy link

veloxy commented Aug 16, 2021

How long is too long? If a product is out of stock indefinitely, you may want to set up a temporary redirect to an alternative. That is the only use case I can think of.

@loevgaard
Copy link
Member Author

Is that how people handle that use case, @veloxy? What I see around on stores is that stores still show the old product, but tell the user that they can get a similar product on another URL or they do a 301 redirect to begin with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants