Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a way to templatize and automatically generate the Jobs config #41

Open
MilesBHuff opened this issue Jan 28, 2020 · 6 comments
Assignees
Labels
feature This is a substantial change to intended behavior. jobs This ticket addresses in-game jobs.
Projects

Comments

@MilesBHuff
Copy link
Member

The Jobs config is ridiculously large. We cannot hope to properly manage it as it is. If we could create a template file, then we could create a script that would perfectly generate most of the Jobs config for us.

@MilesBHuff MilesBHuff added the feature This is a substantial change to intended behavior. label Jan 28, 2020
@MilesBHuff MilesBHuff self-assigned this Jan 28, 2020
@MilesBHuff MilesBHuff added the jobs This ticket addresses in-game jobs. label Jun 22, 2020
@MilesBHuff
Copy link
Member Author

We're going to have to do this for 1.16, since we're at the point where we have to manually develop our Jobs settings (since we've diverged so radically from upstream).

@MilesBHuff MilesBHuff changed the title Come up with a way to templatize the Jobs config and automatically generate most of it Come up with a way to templatize automatically generate the Jobs config Jul 20, 2020
@MilesBHuff MilesBHuff changed the title Come up with a way to templatize automatically generate the Jobs config Come up with a way to templatize and automatically generate the Jobs config Aug 17, 2020
@MilesBHuff MilesBHuff pinned this issue Jul 26, 2021
@MilesBHuff
Copy link
Member Author

One way to do this, is to have a file for every release of Minecraft, with just the blocks it added to the game listed. Then, when we update to a new version, all we'll need is a list of the new blocks in a new file. Easy.

@MilesBHuff
Copy link
Member Author

We could have a base value for each block. We could have a modifier for each job, which increases or decreases the base values for that job. We could also have job-specific overrides.

@MilesBHuff
Copy link
Member Author

We can't limit each block to only one job -- Miner gets paid by breaking the same blocks that Builder gets paid for placing, for example.

@MilesBHuff
Copy link
Member Author

Possible syntax:

COOL_BLOCK:
- base_value: 10
- jobs:
  - job_name
    - break
    - place
  - job_name
    - place: 5
  - job_name
    - break

@MilesBHuff
Copy link
Member Author

I can parse the files and store them in an object, and then use that object to generate the configs Jobs expects to have.

@MilesBHuff MilesBHuff added this to Ready in Jobs Rework Aug 9, 2021
@MilesBHuff MilesBHuff added this to the Update to 1.16 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This is a substantial change to intended behavior. jobs This ticket addresses in-game jobs.
Projects
Development

No branches or pull requests

1 participant