Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding scraping methods to a class #9

Open
ajaysub110 opened this issue May 17, 2020 · 2 comments · May be fixed by #10
Open

Adding scraping methods to a class #9

ajaysub110 opened this issue May 17, 2020 · 2 comments · May be fixed by #10
Assignees
@rohantheowen

Comments

@ajaysub110
Copy link
Member

  • As of now, tweet_basic_scraping.py contains independent functions hardcoded username and dates. We should add these methods to a common class definition which will take username, dates etc as arguments for __init__.
  • We should also add a scrape method that does all the scraping and adding to csv without having to call all the functions separately.
@ajaysub110 ajaysub110 reopened this May 17, 2020
@ajaysub110 ajaysub110 mentioned this issue May 17, 2020
Open
@rohantheowen
Copy link

@ajaysub110 As discussed earlier, can I take up this issue?

@ajaysub110
Copy link
Member Author

Sure, please do

@rohantheowen rohantheowen linked a pull request Jun 26, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohantheowen rohantheowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added methods to a common class definition rohantheowen/twitter-sanity
2 participants
@ajaysub110 @rohantheowen