-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Thumbnails/Snapshots/etc not showing up when sent to a notification group and multiple false positive with a single zone specified #77
Comments
Thanks for doing the digging on this one. It's probably the solution to #45 . I don't know why it it broken with groups. As you saw yourself, it works for non groups and it works for android regardless of groups. It's not meant to need the base url. In fact ideally we wouldn't use it because we can get the images locally instead of via the internet. The additional oddity it is it isn't broken for everyone. Again see the issue linked above. Historically the base url was only needed for things like accessing the clips and snapshots from the action buttons.
I don't really understand this change. How did you pick 2? By my analysis, you are essentially saying it needs to be in 3 matching zones by doing that. Besides the fact it should not work I'm curious to the logic. I'd like to see some debug outputs if you can enable it and past them here. Instructions are available here https://github.com/SgtBatten/HA_blueprints/blob/main/Frigate%20Camera%20Notifications/Guide%3A%20Debug%20Option.md |
I may have a solution. Please test with the beta version in the pull request above. |
Updated will report back on how it goes. So far the thumbnail on iOS disappeared again. Takes a while for someone to drive by the right way for the camera to trigger the false positive. Will report back. Noticed there still are some missing {{base_url}}
And it says {{base_ur}} here instead of {{base_url}} HA_blueprints/Frigate Camera Notifications/Beta Line 1016 in 80dec91
|
@NonaSuomy thanks fixed the missing l The first one should only be used for android so I've left it |
No false positives yet. |
So to confirm. You used the latest version from the pull request which fixed the zoning issue. You also added base urls everywhere in addition to one I added but still don't get thumbnails on iOS? |
Correct on both accounts. I'm going to switch back to what I had before and see if the thumbnail comes back for iOS. I was talking to Amadeo who was able to add to their PR to make the buttons work in HASS.Agent notifications. What this project transmits for buttons at the bottom of the popup. Hopefully, I can test that as well if I can get it to compile. Edit it's working! Yay! https://github.com/amadeo-alex/HASS.Agent.Staging/tree/feature-app-sdk https://github.com/amadeo-alex/HASS.Agent.Staging/commits/feature-app-sdk added option to treat URI elements of notification action like androi… |
I went back to the previous code and the notification image shows back up. |
I assume you've been replacing yaml and then reloading automations? There is potentially a cache issue still (within HA generally) that I reported months ago. Please create a new automation from scratch and see how it goes. |
I smashed your false positives fixes with my old thumbnail working version and seems to be working well now. Thumbnails and no false positives. I was just replacing the Beta.yaml then restarting HA then clicking save on the settings page again. I'll try the new automation thing you said. |
What are the noteworthy differences between your version and the current beta? |
Okay got a chance to test it and the thumbnails still don't work. Seems to be a lot of change between G and L beta. I was trying to slowly copy pasta stuff from L to G but takes forever as I don't want to quickly copy everything and then break it and not know what exact line broke it. |
Don't really need to compare those. (Yet) Sound alike you were on beta g and thumbnails weren't working. Then you made some changes and they were were working. So all I need is those changes to begin with. |
The only changes made were {{ base_url }} on every /api/ line and ?bbox=1 on the image lines. Which I tried on L beta and it didn’t work unfortunately. My modification to G beta was pasted above in that yaml maybe you can notice better than I if there was anything else changed between G and L that may be the culprit? |
I notice in your automation yaml you don't have a base url actually set? |
Also did you at any point actually do a clean install of the latest beta? |
Yes sorry fresh install as my comment before that was “I’ll try what you said with the fresh install” then next was “I finally got to try it” You can see the base url is set below
|
Tried Beta "O" still same issues no thumb on iOS and false positives with only one zone enabled. |
Well I'm probably going to revert all the baseurl changes then. I thought you said it was working? Is it all iOS devices? Have you tried rearranging the devices or temporarily using a smaller list. |
This comment was marked as outdated.
This comment was marked as outdated.
Can you please use this file and see if both issues are resolved https://github.com/SgtBatten/HA_blueprints/blob/beta/Frigate%20Camera%20Notifications/Beta |
Description
I was having issues, when I first set this up using the beta, iOS was working fine with a thumbnail shown. After that, I added a notification group to HA YAML.
For some reason, only the android device was getting an image.
It showed in the Hass.Agent it was getting a bad url (complained about non http uri)
/api/frigate{{client_id}}/notifications/{{id}}/{{attachment}}.jpg?format=android
I then did a test with the developer tools in HA to send this to the hass.agent service. It still didn't show an image on the notification. I then added http://HASSIP:Port in front and boom the image worked on the notification.
Then I looked at the blueprint and noticed there were multiple occurrences missing {{base_url}} throughout it. I modified the blueprint pasted below to add all missing {{base_url}} lines
I'm not sure if auto-set this somehow on something I selected wrong or if it's supposed to be this way but works for others?
Maybe this should be looked at to be prevented or let me know what I did wrong during the setup to cause this.
I noticed in these Blueprint settings it shows that it is missing {{base_url}} in that video string. Not sure if this is the default but that may be one issues?
Blueprint settings
Seems also weird that only the notification group switch made it not work properly.
Let me know if what I did broke anything else or if it actually should be this way with {{base_url}} in front of ever /api line.
Another issue I was having was with a lot of false positives happening even though I only set it to notify me if someone walked in one zone. Seemed to send me notifications on everything until I did this:
Setting this
to 2 seems to have made it quieter and now only triggers on that one zone I specified.
Thank you.
Version
0.12.0.1g
Automation Config
Frigate Config
Any other relevant information
No errors in the log.
The text was updated successfully, but these errors were encountered: