Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Duration Potion Effects Still Present 1.16.4 #268

Closed
Danekjovax opened this issue Dec 13, 2020 · 6 comments
Closed

Infinite Duration Potion Effects Still Present 1.16.4 #268

Danekjovax opened this issue Dec 13, 2020 · 6 comments

Comments

@Danekjovax
Copy link

I saw a closed ticket to this issue, but as of this posting, it is still happening:
image
(excluding Night Vision)

MC 1.16.2
Forge 1.16.4-35.1.4
Apotheosis 1.16.3-4.4.1
Tombstone 6.0.2

Thank you.

@Beserkerlel
Copy link

Beserkerlel commented Dec 18, 2020

Having the same issue in the All The Mods 6 pack v1.3.5

I believe the instances I've found on my server come from Tombstone (Corail Tombstone) as they provide an enchant for weapons called Magic Syphon which can transfer positive effects back to the user.

#259 The dev addressed the issue there

@Danekjovax
Copy link
Author

Yes, it is Magic Siphon that is causing this. Thanks for the link. I'll review it and add what I have found, if helpful.

@Shadows-of-Fire
Copy link
Owner

Duplicate of #259 (still weird there's no default time cap, but I suppose at least there's a config)

@Danekjovax
Copy link
Author

I'll check Corail and see if there's something there that can help resolve this. Thanks.

@Beserkerlel
Copy link

Beserkerlel commented Dec 18, 2020

@Danekjovax From what I can gather, tombstone-common config has the max time set to 1440 minutes or 24 hours max duration. The effects appear infinite (and practically are for game playing use if you're regularly killing apotheosis mobs) because minecraft itself displays anything longer than 27 minutes as "* : *" for a hard limit on the display, but is indeed counting down the 24 hours I'd guess. I would change their config to something more reasonable (and viewable) like 10-20 minutes max duration from the enchant. Hope that helps

@Danekjovax
Copy link
Author

@Beserkerlel Thanks for the help! OK, I found the option here:

tombstone-common.toml, line159:
max_duration_magic_siphon = 1440

I am changing it to something more realistic, like 60. Would be nice to scale it depending on the Siphon level, but this should make things a little more reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants