Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create and remove books #2

Merged
merged 11 commits into from Jan 18, 2022
Merged

Conversation

ShadyShawkat
Copy link
Owner

In this PR, I added the following:

Configure store.
Apply logger Middleware.
Use duck pattern for redux file structure.
Define action creators and reducers.
Dispatch add and remove actions.

Copy link

@SajjadAhmad14 SajjadAhmad14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved ✔️ ✔️ ✔️

Hi Shady,

Congratulations 🎉 Thank you for implementing all the requirements 🙏

Please go ahead and merge the branch!

Happy Coding 👏👏👏

Please leave any questions or comments in the PR if you have any doubts or unclarity!

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ShadyShawkat ShadyShawkat merged commit 75508a8 into dev Jan 18, 2022
@ShadyShawkat ShadyShawkat deleted the feature/Create-and-remove-books branch January 18, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants