Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Documentation (specifically what remix-pwa does for you on install) #46

Closed
Brocktho opened this issue Dec 15, 2022 · 5 comments · Fixed by #85
Closed

Request for Documentation (specifically what remix-pwa does for you on install) #46

Brocktho opened this issue Dec 15, 2022 · 5 comments · Fixed by #85
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request high priority An issue that is one of my top priority with regards to remix-pwa new feature I've got a great idea for remix-pwa

Comments

@Brocktho
Copy link

Brocktho commented Dec 15, 2022

Background:
I'm really excited about this project cause I already love Remix and want to have an easy way to create a close to native experience. I was able to get a fresh remix-blues stack up and running with remix-pwa, although I had to remove cypress testing from my CI/CD since Electron was giving me issues and it was just beyond my understanding at this time.

Issue:
I read as much as I could from the README and the Roadmap but I still have questions on how I could learn some of the under the hood implementations or what APIs are directly touched by remix-pwa. I'd love to be able to help on the project or give better feedback but it's hard to know what remix-pwa does or doesn't do. I mean that in the sense of, I see some code generation happening when using the CLI tool, but I had issues using that same CLI tool on a remix application I already have in production, as a result some features of the library are definitely not working after I tried filling in what I could see from a successful fresh install.

Request:

  1. Adding links to useful documentation or other references that go into more detail of what a PWA requires
  2. Adding information surrounding what the CLI tool aims to accomplish and what a user can do to set things up themselves should it fail on an existing application.
  3. Possibly looking at implementing remix-pwa on all existing remix stacks (Blues, Indie, Grunge. Most of it seems ready to go, I just personally experienced issues in the CI/CD pipeline when attempting to run the Cypress tests.)
  4. Add to documentation that CLI issues can happen if comments are present in the root.tsx file.

Final Note:
This is a really amazing project and makes Native Application support seem like an achievable goal for anyone with a remix stack already, I'd just love to have extra documentation so I can do something to help the project along and have more confidence in using it on existing applications.

Edit:
Dug through other issues and found the reason i had CLI issues on an existing project. Comments do seem to break the CLI, removing them all has fixed the issue. Added request 4. as a reuslt.

@Brocktho
Copy link
Author

I have created a PR to address most of these concerns, or at least get started on them.

@ShafSpecs
Copy link
Member

Okay, speaking of which I haven't been able to maintain remix-pwa thanks to college. I'm close to finishing school so I should be having more time for my projects. I would try to be addressing this in the upcoming weeks 👍. Thx a lot for the assistance

@ShafSpecs
Copy link
Member

I am contemplating giving remix-pwa a separate documentation site so that everything is easily available, and navigating the docs becomes easier

@ShafSpecs ShafSpecs pinned this issue Dec 18, 2022
@ShafSpecs ShafSpecs added documentation Improvements or additions to documentation enhancement New feature or request high priority An issue that is one of my top priority with regards to remix-pwa labels Dec 18, 2022
@ShafSpecs ShafSpecs self-assigned this Dec 18, 2022
@Brocktho
Copy link
Author

Brocktho commented Dec 19, 2022

It would definitely be cool to have a remix-pwa site that makes use of its own APIs to be an always available pwa documentation site. I mean somewhat superfluous but a cool idea, showcasing what's happening under the hood as features are utilized. Hell, i might throw together a repo to do something like that and you could host it or extend it. I'll comment back here if i end up getting that done

Edit: Good luck on school, I remember it being a whirlwind of endless shit to do.

@ShafSpecs ShafSpecs added the new feature I've got a great idea for remix-pwa label Jan 1, 2023
@ShafSpecs
Copy link
Member

Update:

https://github.com/ShafSpecs/remix-pwa-docs

Still a work-in-progress but nevertheless underway 👍

@ShafSpecs ShafSpecs linked a pull request May 13, 2023 that will close this issue
@ShafSpecs ShafSpecs unpinned this issue May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request high priority An issue that is one of my top priority with regards to remix-pwa new feature I've got a great idea for remix-pwa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants