Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NHTSA Recall API support #539

Open
amattu2 opened this issue Sep 29, 2023 · 2 comments
Open

NHTSA Recall API support #539

amattu2 opened this issue Sep 29, 2023 · 2 comments

Comments

@amattu2
Copy link

amattu2 commented Sep 29, 2023

Is your feature request related to a problem? Please describe.

NHTSA offers a recalls API which provides information on recalls associated with a year/make/model combination. It would be a great extension to this API wrapper to also support those related endpoints.

Describe the solution you'd like

  • Support querying for Recall information based on a Year/Make/Model
  • Query for specific recall details by campaignNumber

Describe alternatives you've considered

N/A

Additional context

https://www.nhtsa.gov/nhtsa-datasets-and-apis

@ShaggyTech
Copy link
Owner

ShaggyTech commented Oct 2, 2023

@amattu2 Thank you for the feedback and the link to the datasets. I was casually aware of the other APIs but haven't spent much time looking into them as I had no personal use for Recall or Safety Data.

I'll do some research on the other APIs and put it on my TODO list of features to add. I agree that it would be useful and offer a more complete wrapper for the NHTSA. At first glance It shouldn't be too difficult to implement those as they seem to use similar URL structure and return data as the VPIC API does.

@ShaggyTech
Copy link
Owner

@amattu2

I've been working on updating the package internals so I can add support for the different APIs and make sure their responses are correctly typed. This has been mostly completed.

It's slow going as I'm doing this in my spare time but I'm making good progress towards implementing your feature request.

I've decided to start with the Safety Ratings API and have a working wrapper function called safetyRatings(). You can check it out HERE on branch "next". I'll be working on adding wrappers for the other APIs (recalls, complaints, etc.) and then doing some other chores and refactors on my list.

Once completed it will be released as version 4.0.0, as there will be some major breaking changes. For example, I'll be changing the VPIC wrapper functions names to camelCase as opposed to PascalCase as they are now; ex: DecodeVin() --> decodeVin()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants